Inside SWT

Tuesday, June 03, 2008

Fix only the one place

Like Sergent Pepper's Lonely Hearts Club Band (Reprise), "It's getting pretty near the end" for Eclipse 3.4. As always, there is a stream of bug reports coming in, 99.9% won't get fixed for this release.

We did fix 235219 yesterday (Cheese in tree). It was a regression from 3.3 that had a big visual impact on Eclipse. Amazingly, it was only reported just now. The underlying problem was that the Windows message TVM_GETVISIBLECOUNT returns only the fully visible item count of a tree and we made the mistake of thinking that it included the partially obscured item at the bottom. The fix was to change a "<" to a "<=".

TVM_GETVISIBLECOUNT is used in other places. After a careful analysis, we decided that we wouldn't change them. The code is wrong, but we've done our testing, the impact is low and it's too late. Better to fix only the one place and leave bugs in, than blow the release.



Post a Comment

<< Home